Repository navigation
DEV-1215 Raw Audio config option for Shimmer3R (internal use) - #329
Closed
harithjamadi wants to merge 3 commits into
Closed
harithjamadi wants to merge 3 commits into
harithjamadi wants to merge 3 commits into
Conversation
Config byte 218 (SD trial config 1), bit 1: the audiorec9 bench firmware stores the microphone WAV beside the fingerprint only when it is set. Shimmer3R LogAndStream v1.1.21 and later.
Stored in the config map as Raw_Audio and read back, cleared with the default config, and ignored on devices that do not support it.
Off by default, so any app that has not switched it on writes the bit as 0 and a config write clears raw audio on the device.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
No open issues 🎉
What changed in this PR
Adds gated Shimmer3R Raw Audio configuration support for compatible LogAndStream firmware.
Changes:
- Adds the Raw Audio configuration option and database mapping.
- Reads and writes SD experiment config byte 1, bit 1.
- Restricts enabling Raw Audio to explicitly authorized apps.
| File | Description |
|---|---|
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerObject.java |
Handles Raw Audio state, persistence, and serialization. |
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerDevice.java |
Adds the Raw Audio database configuration key. |
ShimmerDriver/src/main/java/com/shimmerresearch/driver/shimmer2r3/ConfigByteLayoutShimmer3.java |
Defines the Raw Audio bit layout. |
ShimmerDriver/src/main/java/com/shimmerresearch/driver/Configuration.java |
Registers the compatible Shimmer3R configuration option. |
Review effort: Lite
Contributor
Author
|
Closing: DEV-1215 audio sync is experimental for now, not for merging. The DEV-1215 branch stays for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Shimmer3R Raw Audio config option (SD experiment config byte, bit 1) used by the DEV-1215 audio sync work.
Configuration.Shimmer3.GuiLabelConfig.RAW_AUDIOoption, compatible with Shimmer3R LogAndStream 1.1.21 and later.ShimmerObject.setRawAudioAllowed, off by default). Consensys turns it on for internal builds only, so other apps always write it as 0.Merge order
setRawAudioAllowed)Testing
ShimmerDrivertests pass.